Support proto_compiled_sources
with ts_project
#378
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain contexts, we want to be able to use
proto_compiled_sources
withts_project
.ts_project
has the behavior that it willcopy_to_bin
all files named insrcs
that are source files (starlark File APIfile.is_source
).This presents a problem because if we have a
proto_compile
rule in the same package as ats_project
rule, they will attempt to produce the same (conflicting) file in the output tree.This PR introduces attributes to the
proto_compile
rule that will (1) optionally suppress returning aDefaultInfo
provider as well as (2) ability to rename the final output files to have a suffix (so as not to conflict with onests_project
wants to produce).The
proto_compiled_sources
macro has been refactored to support these attributes and use case above.