fix: undefined is rendered as link if --no-template is passed #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aslemammad
requested changes
Aug 6, 2024
| @@ -91,7 +91,7 @@ ${templatesStr} | |||
|
|
|||
| function generateTemplatesStr(templates: Record<string, string>) { | |||
| const entries = Object.entries(templates).filter(([k]) => k !== "default"); | |||
| let str = `[Open in Stackblitz](${templates["default"]})`; | |||
| let str = templates["default"] ? `[Open in Stackblitz](${templates["default"]})` : ''; | |||
|
|
|||
| if (entries.length && entries.length <= 2) { | |||
| str += ` • ${entries.map(([k, v]) => `[${k}](${v})`).join(" • ")}`; | |||
There was a problem hiding this comment.
Can we remove the first dot if the default template is not there.
There was a problem hiding this comment.
Will there be a case when default template is not there but other templates are?
brc-dd
commented
Aug 6, 2024
Co-authored-by: Divyansh Singh <40380293+brc-dd@users.noreply.github.com>
Aslemammad
approved these changes
Aug 6, 2024
|
I think this commit was removed from main from one of force pushes? 😅 It's still rendering links as undefined 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
example - vuejs/vitepress#4100 (comment)
there is also an extra bullet at end in that comment, but I guess it's because #166 isn't released yet?