fix: Pass stdio for interactive editing #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gix_command by default does not pass stdin to commands. This caused editors and shells to behave weirdly. For example, vim printed a warning during opening: Vim: Warning: Input is not from a terminal After closing vim started this way, the terminal was messed up and needed an reset to print outputs correctly (see stgit#415). Signed-off-by: Felix Maurer <felix@felix-maurer.de>
|
Thanks for this PR, @skyfmmf. On which platform(s) did you observe this behavior? |
I'm seeing this with this environment:
|
|
Thanks. I have a similar environment, but using neovim instead of vim. I can reproduce the behavior with vim, but do not see it with neovim or emacsclient. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gix_command by default does not pass stdin to commands. This caused editors and shells to behave weirdly. For example, vim printed a warning during opening:
Vim: Warning: Input is not from a terminal
After closing vim started this way, the terminal was messed up and needed an reset to print outputs correctly.
This is an attempt to fix #415. It fixes the issue described there, but I can not say how it will affect other editors or even scripts. It may re-introduce some errors that 048f182 ("fix: use gix-command for interactive edit") originally tried to fix.
Closes #415