Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable SMS Labs for CI #426

Merged
merged 22 commits into from
Sep 17, 2024
Merged

Enable SMS Labs for CI #426

merged 22 commits into from
Sep 17, 2024

Conversation

bertiethorpe
Copy link
Member

@bertiethorpe bertiethorpe commented Aug 14, 2024 •
edited by sjpb
Loading

  • Re-enables running CI on (new) SMSlabs
  • Can now tag PRs with CI_CLOUD=... to make the stackhpc.yml run on a particular cloud
  • Can now select the CI cloud when triggering the fatimage.yml workflow manually

@bertiethorpe bertiethorpe requested a review from sjpb August 14, 2024 13:30
@bertiethorpe bertiethorpe self-assigned this Aug 14, 2024
@bertiethorpe bertiethorpe changed the title configure SMS deployment SMS Labs deployment Aug 14, 2024
@sjpb
Copy link
Collaborator

sjpb commented Aug 14, 2024

@bertiethorpe we'll also need an appropriate environment/.stackhpc/SMS.pkrvars.hcl file to define the same stuff for packer builds on sms-labs. Unlike the existing ones it can't use a floating IP, it'll need bastion configuration instead. See the openstack packer docs.

@sjpb sjpb changed the title SMS Labs deployment Enable SMS Labs for CI Aug 15, 2024
@sjpb sjpb force-pushed the sms-deploy branch 11 times, most recently from 5a2f5d8 to 3d53521 Compare August 15, 2024 14:02
@bertiethorpe

This comment was marked as outdated.

Sign in to view
@bertiethorpe

This comment was marked as outdated.

Sign in to view
@bertiethorpe
Copy link
Member Author

https://github.com/stackhpc/ansible-slurm-appliance/actions/runs/10451752138

@bertiethorpe bertiethorpe marked this pull request as ready for review August 19, 2024 13:48
@bertiethorpe bertiethorpe requested a review from a team as a code owner August 19, 2024 13:48
@bertiethorpe bertiethorpe requested a review from sd109 August 19, 2024 13:49
sjpb
sjpb requested changes Sep 4, 2024
View reviewed changes
.github/workflows/fatimage.yml Show resolved Hide resolved
environments/.stackhpc/terraform/main.tf Outdated Show resolved Hide resolved
@bertiethorpe
Copy link
Member Author

https://github.com/stackhpc/ansible-slurm-appliance/actions/runs/10700305057

@bertiethorpe
Copy link
Member Author

Build: https://github.com/stackhpc/ansible-slurm-appliance/actions/runs/10700649561

@sjpb sjpb self-requested a review September 4, 2024 13:03
sjpb
sjpb previously approved these changes Sep 4, 2024
View reviewed changes
Copy link
Collaborator

@sjpb sjpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but lets merge after #428

@sjpb
Copy link
Collaborator

sjpb commented Sep 4, 2024

Actually - we need images in SMSlabs to test this anyway 😢

@bertiethorpe bertiethorpe requested review from sjpb and sd109 September 13, 2024 14:57
sjpb
sjpb approved these changes Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@sjpb sjpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjpb sjpb merged commit 17a2432 into main Sep 17, 2024
2 checks passed
@sjpb sjpb deleted the sms-deploy branch September 17, 2024 15:30
MaxBed4d pushed a commit that referenced this pull request Oct 15, 2024
@bertiethorpe @sjpb @MaxBed4d
Enable SMS Labs for CI (#426)
cabdd99 
* configure SMS deployment

* add slurm-app-ci user

* bastion config

* allow overriding CI_CLOUD for PRs using label

* choose cloud for fatimage workflow_dispatch

* packer build qcows

* bump fatimage

* update packer common vars

* Update fatimage.yml

* Update main.tf images

* Update fatimage.yml

* revert fatimage.yml changes

* Update fatimage.yml

* Update fatimage.yml

* hcl packer var put string in quotes

---------

Co-authored-by: Steve Brasier <steveb@stackhpc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjpb sjpb sjpb approved these changes

@sd109 sd109 Awaiting requested review from sd109

Assignees

@bertiethorpe bertiethorpe

Labels
CI_CLOUD=SMS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bertiethorpe @sjpb @sd109