Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Onboard IaaS security group rule commands #523

Merged
merged 21 commits into from
Dec 12, 2024
Merged

Onboard IaaS security group rule commands #523

merged 21 commits into from
Dec 12, 2024

Conversation

GokceGK
Copy link
Contributor

@GokceGK GokceGK commented Dec 5, 2024

No description provided.

Fyusel
Fyusel reviewed Dec 6, 2024
View reviewed changes
Copy link
Contributor

@Fyusel Fyusel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet finished need to have another look on monday.

internal/cmd/beta/security-group-rule/create/create.go Outdated Show resolved Hide resolved
internal/cmd/beta/security-group-rule/create/create.go Outdated Show resolved Hide resolved
internal/cmd/beta/security-group-rule/create/create.go Outdated Show resolved Hide resolved
internal/cmd/beta/security-group-rule/create/create_test.go Outdated Show resolved Hide resolved
internal/cmd/beta/security-group-rule/list/list.go Outdated Show resolved Hide resolved
GokceGK and others added 12 commits December 10, 2024 08:46
@GokceGK @Fyusel
Update internal/cmd/beta/security-group-rule/create/create.go
ac8fba6 
Co-authored-by: Alexander Dahmen <alexander.dahmen@inovex.de>
@GokceGK @Fyusel
Update internal/cmd/beta/security-group-rule/create/create.go
963d740 
Co-authored-by: Alexander Dahmen <alexander.dahmen@inovex.de>
@GokceGK @Fyusel
Update internal/cmd/beta/security-group-rule/list/list.go
a9e1dd8 
Co-authored-by: Alexander Dahmen <alexander.dahmen@inovex.de>
@GokceGK @Fyusel
Update internal/cmd/beta/security-group-rule/create/create_test.go
1104f08 
Co-authored-by: Alexander Dahmen <alexander.dahmen@inovex.de>
@GokceGK
fix unit tests
5ff0eff
@GokceGK @Fyusel
Update internal/cmd/beta/security-group-rule/delete/delete_test.go
281a844 
Co-authored-by: Alexander Dahmen <alexander.dahmen@inovex.de>
@GokceGK @Fyusel
Update internal/cmd/beta/security-group-rule/delete/delete_test.go
93efa2b 
Co-authored-by: Alexander Dahmen <alexander.dahmen@inovex.de>
@GokceGK @Fyusel
Update internal/cmd/beta/security-group-rule/delete/delete_test.go
0ba7563 
Co-authored-by: Alexander Dahmen <alexander.dahmen@inovex.de>
@GokceGK
fix unit tests
3d3f1a2
@GokceGK
update docs
057dcd3
@GokceGK
Merge branch 'main' into gg/onboard-iaas-security-group-rule-commands
1faa0be
@GokceGK
fix linter issues
19d1ee9
Fyusel
Fyusel previously approved these changes Dec 10, 2024
View reviewed changes
@GokceGK GokceGK merged commit 49589d5 into main Dec 12, 2024
3 checks passed
@GokceGK GokceGK deleted the gg/onboard-iaas-security-group-rule-commands branch December 12, 2024 12:54
@GokceGK GokceGK restored the gg/onboard-iaas-security-group-rule-commands branch December 12, 2024 12:54
@GokceGK GokceGK deleted the gg/onboard-iaas-security-group-rule-commands branch December 12, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaopalet joaopalet joaopalet approved these changes

@Fyusel Fyusel Fyusel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GokceGK @Fyusel @joaopalet