-
Notifications
You must be signed in to change notification settings - Fork 5
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Only Delete LoadBalancerMachine after a grace period (#267)
* WIP * fix setCondition * Add more tests than is probably needed * unfocus * iterate over required conditions first * configure yawollet exponential backoff * feedbackc omments * rewrite condition helper to mimic apimachinery/meta * cap and document yawollet backoff * final PR feedback * cleanup * Build images on all branches * Use status subresource client where necessary * Bump chart version in preparation for release * Deflake test --------- Co-authored-by: Tim Ebert <timebertt@gmail.com>
- Loading branch information
Showing
16 changed files
with
529 additions
and
139 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,118 @@ | ||
| package loadbalancerset | ||
|
|
||
| import ( | ||
| "fmt" | ||
|
|
||
| yawolv1beta1 "github.com/stackitcloud/yawol/api/v1beta1" | ||
| "github.com/stackitcloud/yawol/internal/helper" | ||
| corev1 "k8s.io/api/core/v1" | ||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
| ) | ||
|
|
||
| var relevantLBMConditionslForLBS = []helper.LoadbalancerCondition{ | ||
| helper.ConfigReady, | ||
| helper.EnvoyReady, | ||
| helper.EnvoyUpToDate, | ||
| } | ||
|
|
||
| // areRelevantConditionsMet checks if all required conditions (from the | ||
| // perspective of the LoadBalancerSet) are both `True` and up-to-date, according | ||
| // to the passed expiration time. If `stableConditions` is set, a condition is | ||
| // only considered `False` if it has been in that state since the expiration | ||
| // time. | ||
| func areRelevantConditionsMet( | ||
| machine *yawolv1beta1.LoadBalancerMachine, | ||
| expiration metav1.Time, | ||
| stableConditions bool, | ||
| ) (ok bool, reason string) { | ||
| if machine.Status.Conditions == nil { | ||
| return false, "no conditions set" | ||
| } | ||
|
|
||
| // constuct lookup map | ||
| conditions := *machine.Status.Conditions | ||
| condMap := make(map[helper.LoadbalancerCondition]corev1.NodeCondition, len(conditions)) | ||
| for i := range conditions { | ||
| condMap[helper.LoadbalancerCondition(conditions[i].Type)] = conditions[i] | ||
| } | ||
|
|
||
| for _, typ := range relevantLBMConditionslForLBS { | ||
| condition, found := condMap[typ] | ||
| if !found { | ||
| return false, fmt.Sprintf("required condition %s not present on machine", typ) | ||
| } | ||
|
|
||
| conditionIsStable := true | ||
| if stableConditions { | ||
| conditionIsStable = condition.LastTransitionTime.Before(&expiration) | ||
| } | ||
| if conditionIsStable && condition.Status != corev1.ConditionTrue { | ||
| return false, fmt.Sprintf( | ||
| "condition %s is in status %s with reason: %v, message: %v, lastTransitionTime: %v", | ||
| condition.Type, condition.Status, condition.Reason, condition.Message, condition.LastTransitionTime, | ||
| ) | ||
| } | ||
| if condition.LastHeartbeatTime.Before(&expiration) { | ||
| return false, fmt.Sprintf("condition %s heartbeat is stale", condition.Type) | ||
| } | ||
| } | ||
|
|
||
| return true, "" | ||
| } | ||
|
|
||
| func findDeletionCondition(machine *yawolv1beta1.LoadBalancerMachine) *corev1.NodeCondition { | ||
| if machine.Status.Conditions == nil { | ||
| return nil | ||
| } | ||
| conditions := *machine.Status.Conditions | ||
| for i := range conditions { | ||
| if conditions[i].Type == helper.DeletionMarkerCondition { | ||
| return &conditions[i] | ||
| } | ||
| } | ||
| return nil | ||
| } | ||
|
|
||
| func setDeletionCondition(machine *yawolv1beta1.LoadBalancerMachine, newCondition corev1.NodeCondition) { | ||
| if machine.Status.Conditions == nil { | ||
| machine.Status.Conditions = &[]corev1.NodeCondition{} | ||
| } | ||
|
|
||
| newCondition.Type = helper.DeletionMarkerCondition | ||
|
|
||
| existingCondition := findDeletionCondition(machine) | ||
| if existingCondition == nil { | ||
| if newCondition.LastTransitionTime.IsZero() { | ||
| newCondition.LastTransitionTime = metav1.Now() | ||
| } | ||
| *machine.Status.Conditions = append(*machine.Status.Conditions, newCondition) | ||
| return | ||
| } | ||
|
|
||
| if existingCondition.Status != newCondition.Status { | ||
| existingCondition.Status = newCondition.Status | ||
| if !newCondition.LastTransitionTime.IsZero() { | ||
| existingCondition.LastTransitionTime = newCondition.LastTransitionTime | ||
| } else { | ||
| existingCondition.LastTransitionTime = metav1.Now() | ||
| } | ||
| } | ||
|
|
||
| existingCondition.Reason = newCondition.Reason | ||
| existingCondition.Message = newCondition.Message | ||
| existingCondition.LastHeartbeatTime = newCondition.LastHeartbeatTime | ||
| } | ||
|
|
||
| func removeDeletionCondition(machine *yawolv1beta1.LoadBalancerMachine) { | ||
| if machine.Status.Conditions == nil || len(*machine.Status.Conditions) == 0 { | ||
| return | ||
| } | ||
| newConditions := make([]corev1.NodeCondition, 0, len(*machine.Status.Conditions)-1) | ||
| for _, condition := range *machine.Status.Conditions { | ||
| if condition.Type != helper.DeletionMarkerCondition { | ||
| newConditions = append(newConditions, condition) | ||
| } | ||
| } | ||
|
|
||
| *machine.Status.Conditions = newConditions | ||
| } |
Oops, something went wrong.