Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for kubernetes 1.24.x #106

Merged
merged 18 commits into from
Feb 2, 2023
Merged

add support for kubernetes 1.24.x #106

merged 18 commits into from
Feb 2, 2023

Conversation

breuerfelix
Copy link
Contributor

No description provided.

@breuerfelix
set correct k8s version in tests and fix secretname in status
467023f 
Signed-off-by: Felix Breuer <fbreuer@pm.me>
@dergeberl dergeberl linked an issue Jan 25, 2023 that may be closed by this pull request
Support k8s >= 1.24.x #98
Closed
@breuerfelix breuerfelix changed the title [WIP] add support for kubernetes 1.24.x add support for kubernetes 1.24.x Jan 26, 2023
dergeberl
dergeberl requested changes Jan 27, 2023
View reviewed changes
api/v1beta1/loadbalancermachine_types.go Outdated Show resolved Hide resolved
controllers/yawol-controller/loadbalancermachine/suite_test.go Outdated Show resolved Hide resolved
controllers/yawol-controller/loadbalancermachine/suite_test.go Outdated Show resolved Hide resolved
internal/helper/kubernetes/version.go Outdated Show resolved Hide resolved
breuerfelix and others added 5 commits January 27, 2023 10:18
@breuerfelix @dergeberl
Update controllers/yawol-controller/loadbalancermachine/suite_test.go
365f6b5 
Co-authored-by: Maximilian Geberl <48486938+dergeberl@users.noreply.github.com>
Signed-off-by: Felix Breuer <fbreuer@pm.me>
@breuerfelix @dergeberl
Update internal/helper/kubernetes/version.go
1249373 
Co-authored-by: Maximilian Geberl <48486938+dergeberl@users.noreply.github.com>
Signed-off-by: Felix Breuer <fbreuer@pm.me>
@breuerfelix @dergeberl
Update api/v1beta1/loadbalancermachine_types.go
8ac3503 
Co-authored-by: Maximilian Geberl <48486938+dergeberl@users.noreply.github.com>
Signed-off-by: Felix Breuer <fbreuer@pm.me>
@breuerfelix
rename secretName and use kubernetes version in tests
ba9bf7d 
Signed-off-by: Felix Breuer <fbreuer@pm.me>
@breuerfelix
Merge branch 'main' into feature/k8s-v1.24
d629aaa
@breuerfelix breuerfelix requested a review from dergeberl January 30, 2023 10:36
@breuerfelix
add rbac rules to allow modifications to secrets
ea6814b 
Signed-off-by: Felix Breuer <fbreuer@pm.me>
@breuerfelix
restructure creation of serviceaccount secret
f872694 
Signed-off-by: Felix Breuer <fbreuer@pm.me>
@breuerfelix
Merge branch 'main' into feature/k8s-v1.24
def5501
@breuerfelix
add version compare functions
ead4004 
Signed-off-by: Felix Breuer <fbreuer@pm.me>
@breuerfelix
update deps
6064e47 
Signed-off-by: Felix Breuer <fbreuer@pm.me>
dergeberl
dergeberl approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@dergeberl dergeberl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@breuerfelix breuerfelix merged commit b0f3e1c into main Feb 2, 2023
@breuerfelix breuerfelix deleted the feature/k8s-v1.24 branch February 2, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dergeberl dergeberl dergeberl approved these changes

@einfachnuralex einfachnuralex Awaiting requested review from einfachnuralex einfachnuralex is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support k8s >= 1.24.x
2 participants
@breuerfelix @dergeberl