Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update controller-runtime #205

Merged
merged 4 commits into from
Jul 19, 2023
Merged

Update controller-runtime #205

merged 4 commits into from
Jul 19, 2023

Conversation

dergeberl
Copy link
Member

  • Update go version to 1.20

  • Update controller-runtime, controller-tools

  • Add tests that run on multible k8s versions

@dergeberl dergeberl requested a review from timebertt July 18, 2023 14:50
Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, some suggestions for simplification inline.

go.mod Outdated Show resolved Hide resolved
cmd/yawol-cloud-controller/main.go Outdated Show resolved Hide resolved
cmd/yawol-controller/main.go Outdated Show resolved Hide resolved
cmd/yawol-controller/main.go Outdated Show resolved Hide resolved
cmd/yawol-controller/main.go Outdated Show resolved Hide resolved
cmd/yawollet/main.go Outdated Show resolved Hide resolved
@dergeberl dergeberl requested a review from timebertt July 19, 2023 07:00
Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@dergeberl dergeberl merged commit 54c919e into main Jul 19, 2023
@dergeberl dergeberl deleted the feature/bumpControllerRuntime branch July 19, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants