Add possibility to use multiple loadbalancerClasses and use service.spec.loadBalancerClass
#217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timebertt
reviewed
Jul 20, 2023
controllers/yawol-cloud-controller/targetcontroller/service_controller.go
Show resolved
Hide resolved
controllers/yawol-cloud-controller/targetcontroller/service_controller.go
Show resolved
Hide resolved
controllers/yawol-cloud-controller/targetcontroller/service_controller_test.go
Show resolved
Hide resolved
dergeberl
force-pushed
the
feature/loadbalancerClasses
branch
from
6cd7813 to
b789815
Compare
timebertt
reviewed
Jul 20, 2023
timebertt
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yawol-cloud-controller:
service.spec.loadBalancerClass--empty-classnameflag to also react on services without a class (default is true)Breaking Change because if a
classNamewas set in theyawol-cloud-controlleran empty class would be ignored. To have the same behavior, it is necessary to add--empty-classname. Most likely this is only used in dev/debug scenarios.fix #164