Allow overriding of creation timeout for LoadBalancerMachines
#279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maboehm
requested review from
dergeberl,
einfachnuralex,
Kumm-Kai and
timebertt
as code owners
maboehm
commented
Jan 18, 2024
nschad
reviewed
Jan 18, 2024
controllers/yawol-controller/loadbalancerset/loadbalancerset_controller_test.go
Show resolved
Hide resolved
timebertt
reviewed
Jan 19, 2024
controllers/yawol-controller/loadbalancerset/loadbalancerset_controller_test.go
Show resolved
Hide resolved
timebertt
changed the title
LoadBalancerMachines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LoadbalancerSet controller (specifically the LBM status controller) currently deletes any LBM that takes more than 10 Minutes to report their first condition. This change allows users to override this duration per object by setting the annotation
yawol.stackit.cloud/creationTimeoutonLoadBalancerMachineobjects.