Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Watch/Reconcile triggers of LoadbalancerSet controller #283

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

maboehm
Copy link
Collaborator

@maboehm maboehm commented Jan 23, 2024

Avoid triggering ourselves due to status updates. This should help with yawol creating more LBMs than necessary, as we'd only reconcile 2s after a change to the number of LBMs at which point the cache is very likely up-to-date.

Testing this manually was quite successful, showing e.g. new LBMs are created in about 2s intervals:

$ k get lbm --output custom-columns=name:.metadata.name,age:.status.creationTimestamp
name                                    age
default--nginx-onfufk3nyhpp2vm6-4792a   2024-01-22T17:28:18Z
# scale up to 3
default--nginx-onfufk3nyhpp2vm6-9428f   2024-01-24T14:31:06Z
default--nginx-onfufk3nyhpp2vm6-fe09b   2024-01-24T14:31:04Z
# triggered rolling update
default--nginx-qdbmexfvhnyvjjqq-3eaed   2024-01-24T14:32:58Z
default--nginx-qdbmexfvhnyvjjqq-822ba   2024-01-24T14:33:03Z
default--nginx-qdbmexfvhnyvjjqq-fe3b0   2024-01-24T14:32:57Z

@maboehm maboehm force-pushed the feature/improve-reconcile branch from df2202f to 10a5edb Compare January 24, 2024 14:01
@maboehm maboehm force-pushed the feature/improve-reconcile branch from 10a5edb to 7713c9e Compare January 24, 2024 14:02
@maboehm maboehm marked this pull request as ready for review January 24, 2024 14:41
@maboehm maboehm changed the title WIP: Improve Watch/Reconcile triggers of lbs controller Improve Watch/Reconcile triggers of LoadbalancerSet controller Jan 24, 2024
@dergeberl dergeberl merged commit 19dcae4 into main Feb 14, 2024
1 check passed
@dergeberl dergeberl deleted the feature/improve-reconcile branch February 14, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants