Improve Requeue durations of LoadBalancer Reconciler #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maboehm
requested review from
dergeberl,
einfachnuralex,
Kumm-Kai and
timebertt
as code owners
maboehm
force-pushed
the
feature/improve-lb-reconcile
branch
from
9f8dba2 to
841a051
Compare
dergeberl
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LB controller is careful before scaling down an old LBS, requiring the new LBS to have the keepalived master for at least two minutes. But during that "stability" wait period, it is likely that nothing will trigger another reconcile (LB&LBS are stable at this point), so the next time the reconciler is run is after 5 minutes.
With this change, the check function
helper.LBSetHasKeepalivedMaster()also returns a duration after which it's worth checking again. We use that to determine our next reconcile, making sure to limit this to 5 minutes.