Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏷️ Add labels to Earthfile #321

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Conversation

robinschneider
Copy link
Contributor

Add labels org.opencontainers.image.source and org.opencontainers.image.revision to Earthfile.
This will allow renovate to find release notes for PRs.

@robinschneider robinschneider force-pushed the add-container-image-labels branch from c7c514c to 3d3ddc4 Compare April 16, 2024 12:30
@robinschneider
Copy link
Contributor Author

Tested with earthly +ci
docker image inspect ghcr.io/stackitcloud/yawol/yawol-controller:yawol-controller-0.21.3-15-g8ec7594

"Labels": {
                "dev.earthly.built-by": "homebrew-earthly",
                "dev.earthly.git-sha": "e77372274b09b5e5f8a42f1b6ac264f7149c4924",
                "dev.earthly.version": "v0.7.23",
                "org.opencontainers.image.revision": "8ec7594a27a01d6c184db71cc06a5fef8ea42790",
                "org.opencontainers.image.source": "https://github.com/stackitcloud/yawol"
            }

Kumm-Kai
Kumm-Kai previously approved these changes Apr 16, 2024
Copy link
Member

@Kumm-Kai Kumm-Kai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙂

We've decided to drop BUILD +set-version and it doesn't seem to be needed, but maybe someone else knows if we can really drop it.

@hown3d
Copy link
Contributor

hown3d commented Apr 16, 2024

BUILD +set-version could be used to set the label org.opencontainers.image.version

@robinschneider
Copy link
Contributor Author

BUILD +set-version could be used to set the label org.opencontainers.image.version

Added it as well

@robinschneider robinschneider merged commit 54fd8a4 into main Apr 16, 2024
2 checks passed
@robinschneider robinschneider deleted the add-container-image-labels branch April 16, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants