Ignore terminating nodes #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelEischer
requested review from
dergeberl,
einfachnuralex,
Kumm-Kai,
timebertt and
maboehm
as code owners
Kumm-Kai
requested changes
Jul 8, 2024
controllers/yawol-cloud-controller/targetcontroller/node_controller_test.go
Outdated
Show resolved
Hide resolved
controllers/yawol-cloud-controller/targetcontroller/node_controller_test.go
Outdated
Show resolved
Hide resolved
controllers/yawol-cloud-controller/targetcontroller/node_controller_test.go
Outdated
Show resolved
Hide resolved
controllers/yawol-cloud-controller/targetcontroller/node_controller_test.go
Outdated
Show resolved
Hide resolved
controllers/yawol-cloud-controller/targetcontroller/node_controller_test.go
Outdated
Show resolved
Hide resolved
Kumm-Kai
approved these changes
Jul 15, 2024
Kumm-Kai
force-pushed
the
ignore-terminating-machines
branch
from
6bd2aff to
509a613
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generic Kubernetes cloud-controller-manager implementation ignores nodes that are marked with the
ToBeDeletedByClusterAutoscalertaint (see https://github.com/kubernetes/cloud-provider/blob/81e4f58b4d1badd71d633d356faaaf69d971d874/controllers/service/controller.go#L64). This PR let's yawol also ignore those nodes.In addition, the
Terminatingcondition set by the Gardener machine-controller-manager is also considered. This should allow yawol to avoid sending new traffic to nodes that are about to be shut down.