allow yawol to work with self-signed OpenStack APIs #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nschad
requested review from
dergeberl,
einfachnuralex,
Kumm-Kai,
timebertt and
maboehm
as code owners
hown3d
force-pushed
the
add-custom-ca-file-capability
branch
from
afa7706 to
3a3b7b9
Compare
|
We also added the possibility to add |
hown3d
changed the title
dergeberl
reviewed
Aug 19, 2024
There was a problem hiding this comment.
LGTM, only one nit.
Please document this feature in the readme.
https://github.com/stackitcloud/yawol?tab=readme-ov-file#cluster-installation
nschad
changed the title
Signed-off-by: Niclas Schad <niclas.schad@stackit.de>
Signed-off-by: Niclas Schad <niclas.schad@stackit.de>
Signed-off-by: Niclas Schad <niclas.schad@stackit.de>
Signed-off-by: Lukas Hoehl <lukas.hoehl@stackit.de>
Signed-off-by: Lukas Hoehl <lukas.hoehl@stackit.de>
Signed-off-by: Niclas Schad <niclas.schad@stackit.de>
nschad
force-pushed
the
add-custom-ca-file-capability
branch
from
18b2ad3 to
7c44dff
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
This PR adds the capability to use yawol against self-signed keystone Providers by reading
ca-filefrom the cloud-config.