Fix unnecessary keepalived switches due to unhealthy condition #423
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, a change (like nodes or ports) triggered an unnecessary keepalived failover.
It happened that the envoy did not have the new snapshot version here:
yawol/controllers/yawollet/loadbalancer_controller.go
Lines 162 to 167 in 609b3e0
This results in a
false
EnvoyUpToDate
condition. That will not be fixed until the requeue time (30s) but the keepalived healthcheck of yawollet fails which results in an unnecessary keepalived failover.I think the best way to solve this is to use the same check for unready conditions and return an error to requeue with backoff.