Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add additional networks #80

Merged
merged 11 commits into from
Jan 5, 2023
Merged

add additional networks #80

merged 11 commits into from
Jan 5, 2023

Conversation

dergeberl
Copy link
Member

@dergeberl dergeberl commented Dec 9, 2022

Related #50

Changes in yawol-controller:

  • mv lb.spec.infrastructure.floatingNetID and lb.spec.infrastructure.networkID to lb.spec.infrastructure.defaultNetwork
  • deprecate lb.spec.infrastructure.floatingNetID and lb.spec.infrastructure.networkID
  • mv lbm.status.portID to lbm.status.defaultPortID
  • deprecate lbm.status.portID
  • add lbm.status.defaultPortName to be aligned with the LoadBalancer Object
  • handle the port creation and deletion for the lbm like in the lb controller
  • add additional networks (lb.spec.infrastructure.additionalNetworks) to server without any precreated port (precreation is not needed because there are no special settings for this ports
  • add lb.status.portIP to have easy access to the IP from the LoadBalancer Port
  • add lbm.status.defaultPortIP to have easy access to the IP from the LoadBalancerMachine Port
  • add lb.infrastructure.projectID to overwrite the openstack projectID from the secretRef

Changes in yawol-cloud-controller:

  • add yawol.stackit.cloud/additionalNetworks annotation to add additionalNetworks to the lb object
  • add yawol.stackit.cloud/floatingNetworkID annotation to overwrite default floatingNetworkID
  • add yawol.stackit.cloud/defaultNetworkID annotation to overwrite the default network which is set by the yawol-cloud-controller. If enabled it will automatically add the default network ID from the yawol-cloud-controller to lb.spec.infrastructure.additionalNetworks
  • add yawol.stackit.cloud/skipCloudControllerDefaultNetworkID to prevent that the default network ID from the yawol-cloud-controller to lb.spec.infrastructure.additionalNetworks if yawol.stackit.cloud/defaultNetworkID is set
  • add yawol.stackit.cloud/projectID to add the lb.infrastructure.projectID. This field cant be changed.

Changes in yawollet:

  • set the envoy setting DnsLookupFamily in Cluster to Auto (which is also the envoy default)

Changes in yawollet image:

  • use dhcpcd instead if udhcpd to get also IPv6 addresses

go.mod

Co-authored-by: @breuerfelix @einfachnuralex

@dergeberl dergeberl marked this pull request as draft December 9, 2022 17:00
@dergeberl dergeberl force-pushed the feature/additionalNetworks branch 6 times, most recently from 0fac0d0 to ab2d24f Compare December 12, 2022 15:21
@dergeberl dergeberl force-pushed the feature/additionalNetworks branch from 6cab231 to 4451a4b Compare December 21, 2022 13:40
@dergeberl dergeberl marked this pull request as ready for review December 22, 2022 07:13
@dergeberl dergeberl changed the title WIP: additional networks add additional networks Dec 22, 2022
@dergeberl dergeberl force-pushed the feature/additionalNetworks branch from 86635be to b059989 Compare December 22, 2022 10:23
breuerfelix
breuerfelix previously approved these changes Jan 4, 2023
Copy link
Contributor

@breuerfelix breuerfelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@breuerfelix breuerfelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dergeberl dergeberl merged commit 900feca into main Jan 5, 2023
@dergeberl dergeberl deleted the feature/additionalNetworks branch January 5, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants