-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add additional networks #80
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dergeberl
requested review from
einfachnuralex and
breuerfelix
as code owners
December 9, 2022 16:59
nightlyone
reviewed
Dec 11, 2022
dergeberl
force-pushed
the
feature/additionalNetworks
branch
6 times, most recently
from
December 12, 2022 15:21
0fac0d0
to
ab2d24f
Compare
dergeberl
force-pushed
the
feature/additionalNetworks
branch
from
December 21, 2022 13:40
6cab231
to
4451a4b
Compare
…from the secretRef
…ork if default is overwritten
dergeberl
force-pushed
the
feature/additionalNetworks
branch
from
December 22, 2022 10:23
86635be
to
b059989
Compare
nschad
reviewed
Jan 2, 2023
breuerfelix
reviewed
Jan 2, 2023
controllers/yawol-cloud-controller/targetcontroller/service_controller.go
Show resolved
Hide resolved
controllers/yawol-cloud-controller/targetcontroller/service_controller.go
Outdated
Show resolved
Hide resolved
controllers/yawol-cloud-controller/targetcontroller/service_controller.go
Outdated
Show resolved
Hide resolved
controllers/yawol-cloud-controller/targetcontroller/service_controller.go
Outdated
Show resolved
Hide resolved
controllers/yawol-cloud-controller/targetcontroller/service_controller.go
Outdated
Show resolved
Hide resolved
controllers/yawol-controller/loadbalancermachine/loadbalancermachine_controller.go
Outdated
Show resolved
Hide resolved
controllers/yawol-controller/loadbalancermachine/loadbalancermachine_controller.go
Outdated
Show resolved
Hide resolved
controllers/yawol-controller/loadbalancermachine/loadbalancermachine_controller.go
Show resolved
Hide resolved
controllers/yawol-controller/loadbalancermachine/loadbalancermachine_controller.go
Outdated
Show resolved
Hide resolved
breuerfelix
previously approved these changes
Jan 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
breuerfelix
approved these changes
Jan 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #50
Changes in yawol-controller:
lb.spec.infrastructure.floatingNetID
andlb.spec.infrastructure.networkID
tolb.spec.infrastructure.defaultNetwork
lb.spec.infrastructure.floatingNetID
andlb.spec.infrastructure.networkID
lbm.status.portID
tolbm.status.defaultPortID
lbm.status.portID
lbm.status.defaultPortName
to be aligned with the LoadBalancer Objectlb.spec.infrastructure.additionalNetworks
) to server without any precreated port (precreation is not needed because there are no special settings for this portslb.status.portIP
to have easy access to the IP from the LoadBalancer Portlbm.status.defaultPortIP
to have easy access to the IP from the LoadBalancerMachine Portlb.infrastructure.projectID
to overwrite the openstack projectID from the secretRefChanges in yawol-cloud-controller:
yawol.stackit.cloud/additionalNetworks
annotation to add additionalNetworks to thelb
objectyawol.stackit.cloud/floatingNetworkID
annotation to overwrite default floatingNetworkIDyawol.stackit.cloud/defaultNetworkID
annotation to overwrite the default network which is set by theyawol-cloud-controller
. If enabled it will automatically add the default network ID from theyawol-cloud-controller
tolb.spec.infrastructure.additionalNetworks
yawol.stackit.cloud/skipCloudControllerDefaultNetworkID
to prevent that the default network ID from theyawol-cloud-controller
tolb.spec.infrastructure.additionalNetworks
ifyawol.stackit.cloud/defaultNetworkID
is setyawol.stackit.cloud/projectID
to add thelb.infrastructure.projectID
. This field cant be changed.Changes in yawollet:
DnsLookupFamily
inCluster
toAuto
(which is also the envoy default)Changes in yawollet image:
go.mod
Co-authored-by: @breuerfelix @einfachnuralex