Re-enable go CoverageRedesign #3252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the workaround that disabled new compiler-based code coverage tooling due to a bug introduced in go v1.22.0 and fixed in v1.22.2, since we bumped go to v1.22.2 in pr stacklok#3161.
|
|
|
Hey @prezha ! nice to see a commit from you 😄 |
JAORMX
approved these changes
May 7, 2024
|
hey @JAORMX, thanks, always pleasure to contribute! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove the workaround that disabled new compiler-based code coverage tooling due to a bug introduced in go v1.22.0 and fixed in v1.22.2, since we bumped go to v1.22.2 in pr #3161.
Change Type
Mark the type of change your PR introduces:
Testing
Local test results attached: make_cover.log
Review Checklist: