Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE_REQUEST] unset-cpu-requirements should use requirementsType: "request" #459

Open
jholecek-rh opened this issue Dec 6, 2022 · 1 comment
Open

[FEATURE_REQUEST] unset-cpu-requirements should use requirementsType: "request" #459

jholecek-rh opened this issue Dec 6, 2022 · 1 comment
Labels
new-check

Comments

@jholecek-rh
Copy link

Description of the problem/feature request

The requirementsType parameter of the built-in unset-cpu-requirements check is set to any which means that workloads need to specify both CPU requests and CPU limits to pass the check.

This doesn't seem to match the best practices (according to some sources at least) which suggest that:

  • All workloads should set CPU requests
  • Only some workloads should set CPU limits; CPU limits can be actually harmful to some workloads

I suggest softening the built-in check to require only CPU requests to be set.

Description of the existing behavior vs. expected behavior

The current unset-cpu-requirements check sets requirementsType to any.

I am suggesting to change it to request.

Additional context

Nothing to put here.
michaelbeaumont added a commit to kumahq/kuma that referenced this issue Feb 24, 2023
@michaelbeaumont
ci: don't require CPU limits and enable kube-linter checks
f6d8df7 
See stackrox/kube-linter#459
and https://web.archive.org/web/20220805232857/https://home.robusta.dev/blog/stop-using-cpu-limits/
Generally we shouldn't be setting CPU limits on Pods.

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
michaelbeaumont added a commit to kumahq/kuma that referenced this issue Feb 24, 2023
@michaelbeaumont
ci: don't require CPU limits and enable kube-linter checks
2878f7c 
See stackrox/kube-linter#459
and https://web.archive.org/web/20220805232857/https://home.robusta.dev/blog/stop-using-cpu-limits/
Generally we shouldn't be setting CPU limits on Pods.

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont mentioned this issue Feb 24, 2023
Merged
6 tasks
michaelbeaumont added a commit to kumahq/kuma that referenced this issue Feb 28, 2023
@michaelbeaumont
ci: don't require CPU limits and enable kube-linter checks
1f7a546 
See stackrox/kube-linter#459
and https://web.archive.org/web/20220805232857/https://home.robusta.dev/blog/stop-using-cpu-limits/
Generally we shouldn't be setting CPU limits on Pods.

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
michaelbeaumont added a commit to kumahq/kuma that referenced this issue Mar 8, 2023
@michaelbeaumont
ci: don't require CPU limits and enable kube-linter checks
2197364 
See stackrox/kube-linter#459
and https://web.archive.org/web/20220805232857/https://home.robusta.dev/blog/stop-using-cpu-limits/
Generally we shouldn't be setting CPU limits on Pods.

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
michaelbeaumont added a commit to kumahq/kuma that referenced this issue Mar 8, 2023
@michaelbeaumont
ci: don't require CPU limits and enable kube-linter checks
ab73ae4 
See stackrox/kube-linter#459
and https://web.archive.org/web/20220805232857/https://home.robusta.dev/blog/stop-using-cpu-limits/
Generally we shouldn't be setting CPU limits on Pods.

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@tspearconquest
Copy link
Contributor

I work around this currently with an annotation. Having this merged would be appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
new-check
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@janisz @jholecek-rh @tspearconquest