Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Proper coinbase generation #253

Merged
merged 2 commits into from
Jun 26, 2024
Merged

feat: Proper coinbase generation #253

merged 2 commits into from
Jun 26, 2024

Conversation

netrome
Copy link
Contributor

@netrome netrome commented Jun 24, 2024

closes #213

@netrome netrome self-assigned this Jun 24, 2024
@netrome netrome linked an issue Jun 24, 2024 that may be closed by this pull request
[Chore]: Proper coinbase generation in dummy block generator #213
Closed
@netrome netrome force-pushed the 213-chore-proper-coinbase-generation-in-dummy-block-generator branch from d3dd28d to 01df3f7 Compare June 25, 2024 10:14
@netrome netrome marked this pull request as ready for review June 25, 2024 14:34
djordon
djordon approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@djordon djordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

signer/src/testing/dummy.rs Outdated Show resolved Hide resolved
@netrome netrome merged commit 7590931 into main Jun 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djordon djordon djordon approved these changes

@AshtonStephens AshtonStephens Awaiting requested review from AshtonStephens

Assignees

@netrome netrome

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Chore]: Proper coinbase generation in dummy block generator
2 participants
@netrome @djordon