-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Clarity2) Get burnchain_header_hash by burnchain_height #2770
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added some pointers to implementations
…f a clarity block connection and a clarity transaction, so we can test the availability of get-burn-block-info? in the inner environment's epoch
Codecov Report
@@ Coverage Diff @@
## next #2770 +/- ##
==========================================
+ Coverage 83.75% 83.80% +0.05%
==========================================
Files 265 266 +1
Lines 207954 208569 +615
==========================================
+ Hits 174166 174793 +627
+ Misses 33788 33776 -12
Continue to review full report at Codecov.
|
I've merged #3110 into this PR, since I need some of its test infrastructure. Please merge that one first. |
This is now ready for review @kantai @gregorycoppola @lgalabru @obycode |
…ss for get-burn-block-info?.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Fixes #2663
Description
This change allows a clarity contract to get the header hash of a burnchain block using the burchain height. Currently, you can get the header hash of the burnchain only using the Stacks height.
Testing
Tests have been added in the following files:
A TODO was added to modify the following integration test. We avoid doing this now because it will require having a way to configure the Stacks Epoch for the Mocknet miner.