Bootup fixes for 2.05.0.2.0-rc1 #3112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… do it on node boot-up. Also, downgrade the tx type for migraiton to DBTx so we don't accidentally depend on the first block header information (which we might not have)
…s public key, so also make sure that the last contact time is positive when considering timeouts
…ell as the `allowed` column
…to the latest schema before header sync
Codecov Report
@@ Coverage Diff @@
## develop #3112 +/- ##
===========================================
- Coverage 83.71% 83.54% -0.17%
===========================================
Files 260 260
Lines 200932 200982 +50
===========================================
- Hits 168210 167914 -296
- Misses 32722 33068 +346
Continue to review full report at Codecov.
|
gregorycoppola
approved these changes
Apr 22, 2022
kantai
approved these changes
Apr 22, 2022
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a couple of boot-up issues related to schema migrations and always-allowed peers when booting a 2.05.0.2.0-rc1 peer. In particular:
This PR fixes a runtime panic that arises when booting from genesis due to the unavailability of the first block snapshot.
This PR fixes a runtime panic that arises when booting from non-migrated chainstate due to needing the first block snapshot before attempting migrations to the latest schemas.
This PR makes it so that the public key of an always-allowed peer is reset from the config file on each boot-up.
This PR makes it so that an always-allowed peer is only considered to have timed out if it has replied to a previous message first (this is specific to always-allowed peers since they are always considered authenticated, which precludes relying on checking whether or not the public key is known to determine if a peer has been contacted).