Log error instead of crash on failed branch re-alignment #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -444,6 +445,9 @@ export class Manifest { | |||
| parseConfig(github, configFile, changesBranch, path, releaseAs), | |||
| parseReleasedVersions(github, manifestFile, changesBranch), | |||
| ]); | |||
| if (manifestOptions.logger) { | |||
There was a problem hiding this comment.
manifestOptions.logger is an optional logger instance to use. By default release-please relies on a global logger defined in src/util/logger.ts.
When CLI commands are run, setupLogger() is called to do some configuration.
In our case we are using release-please via fromManifest(), and pass the logger via the option. But I'm not convinced release-please correctly use the logger from the options all the time. It is safer to also set the global one to ensure a consistent logging behaviour.
marcel-stainless
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.