Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only auto-merge after creating and updating PRs #56

Merged
merged 3 commits into from
Nov 8, 2023

Conversation

dgellow
Copy link
Member

@dgellow dgellow commented Nov 8, 2023

When updating a pull request, if it is considered auto-mergeable, the auto-merge is done before the PATCH request to update its content/title/state. Given that we set the state to open, that results in an error (a merged PR cannot have its state changed to open).

This pull request makes manifest.ts calls the enableAutoMerge function after this.github.createPullRequest and this.github.updatePullRequest, making it sure that we only merge after any creation or update operation.

@dgellow dgellow merged commit e0e8b96 into main Nov 8, 2023
4 checks passed
@dgellow dgellow deleted the sam/fix-patch-after-auto-merge branch November 8, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants