Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog: filter out commits containing 'chore: release ' #61

Merged

Conversation

dgellow
Copy link
Member

@dgellow dgellow commented Feb 1, 2024

When using multiple packages the commit bumping versions is chore: release. Unfortunately because it is a conventional semantic commit itself it seems to be included in changelogs of sub-packages.

An example of this can be seen in this PR:

Screenshot 2024-02-01 at 15 54 19

Ideally we would have a cleaner way to avoid any release commit without relying on the title but that would require more capacity than we currently have.

Copy link
Member

@RobertCraigie RobertCraigie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sam! How feasible would it be to add a unit test for this case?

@dgellow dgellow enabled auto-merge (squash) February 1, 2024 15:16
@dgellow dgellow merged commit 86495c1 into main Feb 1, 2024
4 checks passed
@dgellow dgellow deleted the sam/sta-3722-ignore-chore-release-commits-in-release-please branch February 1, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants