Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix user configurability and securityContexts. #90

Merged
merged 3 commits into from
Nov 4, 2020
Merged

Fix user configurability and securityContexts. #90

merged 3 commits into from
Nov 4, 2020

Conversation

davidkarlsen
Copy link
Collaborator

@davidkarlsen davidkarlsen commented Nov 4, 2020 •
edited
Loading

Fixes #83.
Obsoletes #85.

This change is Reviewable

@davidkarlsen
Fixes stakater#83, the second issue
4ea4d40 
Signed-off-by: David Karlsen <david@davidkarlsen.com>
@davidkarlsen
Fixes stakater#83, the first issue
5748def 
Signed-off-by: David Karlsen <david@davidkarlsen.com>
@davidkarlsen
Copy link
Collaborator Author

@hamza3202 PTAL?

@stakater-user
Copy link
Contributor

@davidkarlsen Image is available for testing. docker pull stakater/gitwebhookproxy:SNAPSHOT-PR-90-1

@davidkarlsen
put back default users
1314370 
Signed-off-by: David Karlsen <david@davidkarlsen.com>
@stakater-user
Copy link
Contributor

@davidkarlsen Image is available for testing. docker pull stakater/gitwebhookproxy:SNAPSHOT-PR-90-2

@hamza3202 hamza3202 merged commit b64e419 into stakater:master Nov 4, 2020
@hamza3202
Copy link
Contributor

Thanks!

@davidkarlsen
Copy link
Collaborator Author

Why was default values removed in the merge? 9edec1b

@hamza3202 hamza3202 mentioned this pull request Nov 4, 2020
Closed
@davidkarlsen davidkarlsen deleted the issue83 branch November 4, 2020 10:43
@hamza3202
Copy link
Contributor

hamza3202 commented Nov 4, 2020 •
edited
Loading

@davidkarlsen
To make changes to chart values, you have to modify its template i.e in this folder
I have fixed it in PR #91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamza3202 hamza3202 hamza3202 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Misc chart cleanups
3 participants
@davidkarlsen @stakater-user @hamza3202