-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENHANCE] Allow to use auto annotation with specific resource type (configmap or secret) #582
Labels
Comments
@kichel98 if you'd like to submit a pull request for this change, we welcome the change |
kichel98
pushed a commit
to kichel98/Reloader
that referenced
this issue
Jan 19, 2024
…pe (configmap or secret)
kichel98
pushed a commit
to kichel98/Reloader
that referenced
this issue
Jan 19, 2024
…pe (configmap or secret)
@MuneebAijaz Here it is: #604 😄 |
+1 |
MuneebAijaz
added a commit
that referenced
this issue
Apr 8, 2024
…resource-type-squashed [#582] Allow to use auto annotation with specific resource type (configmap or secret)
closing in favour of #604 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Is your feature request related to a problem? Please describe.
I am incorporating Reloader into my project mainly to automatically reload pods after certificates (secrets) change. For most deployments I do not want to allow reloading when configmaps change. But I would prefer not to forbid using Reloader for configmaps changes by setting
ignoreConfigMaps
globally (sometimes configmap reload might be used in my case). In this situation I need to usesecret.reloader.stakater.com/reload: "<secret-list>"
and maintain the<secret-list>
. It would be much easier if I could use auto annotation for a given deployment/statefulset/daemonset but only for secrets.Describe the solution you'd like
Please enhance auto annotation and in addition to
reloader.stakater.com/auto: "true"
allow more specific annotations which allow tofilter watched resources by resource type:
configmap.reloader.stakater.com/auto: "true"
andsecret.reloader.stakater.com/auto: "true"
. E.g. usingsecret.reloader.stakater.com/auto: "true"
will lead to the same behaviour asreloader.stakater.com/auto: "true"
but only for mounted secrets, ignoring configmaps.If you see other options to achieve what I need, please share.
The text was updated successfully, but these errors were encountered: