Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue/562 - enhance documentation for Reloader Chart values.yaml #620

Merged
merged 13 commits into from
Apr 5, 2024
Merged

issue/562 - enhance documentation for Reloader Chart values.yaml #620

merged 13 commits into from
Apr 5, 2024

Conversation

fdberlking
Copy link
Contributor

Problem Statement

Enhance documentation for Helm chart values.yaml

Related Issue

Fixes #562

Proposed Changes

Update documentation within the Readme file for a better and easier understanding of the Reloader configuration.

Checklist

issue/562 - enhance documentation for Reloader Chart values.yaml
c85cb7a 
Signed-off-by: Benjamin Walterscheid <benjamin.walterscheid@de.ibm.com>
github-actions[bot]
github-actions bot reviewed Feb 22, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

@fdberlking Images are available for testing. docker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-620-c85cb7aa\ndocker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-620-UBI-c85cb7aa

issue/562 - aligned unordered list indentation
554e059 
Signed-off-by: Benjamin Walterscheid <benjamin.walterscheid@de.ibm.com>
@github-actions GitHub Actions
Copy link

@fdberlking Images are available for testing. docker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-620-554e059c\ndocker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-620-UBI-554e059c

issue/562 - removed leading reloader due to QA spell check issues
73d839b 
Signed-off-by: Benjamin Walterscheid <benjamin.walterscheid@de.ibm.com>
github-actions[bot]
github-actions bot reviewed Feb 22, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

@fdberlking Images are available for testing. docker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-620-73d839bd\ndocker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-620-UBI-73d839bd

issue/562 - updated failing qa / spell_check README checks
7398ba8 
Signed-off-by: Benjamin Walterscheid <benjamin.walterscheid@de.ibm.com>
@github-actions GitHub Actions
Copy link

@fdberlking Images are available for testing. docker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-620-7398ba8a\ndocker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-620-UBI-7398ba8a

Benjamin Walterscheid added 2 commits February 22, 2024 23:10
issue/562 - updated failing qa / spell_check README checks
75d7a4c 
Signed-off-by: Benjamin Walterscheid <benjamin.walterscheid@de.ibm.com>
issue/562 - updated failing qa / spell_check README checks
c905e2d 
Signed-off-by: Benjamin Walterscheid <benjamin.walterscheid@de.ibm.com>
@github-actions GitHub Actions
Copy link

@fdberlking Images are available for testing. docker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-620-75d7a4cf\ndocker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-620-UBI-75d7a4cf

@github-actions GitHub Actions
Copy link

@fdberlking Images are available for testing. docker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-620-c905e2d8\ndocker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-620-UBI-c905e2d8

@github-actions GitHub Actions
Copy link

@fdberlking Images are available for testing. docker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-620-98efc75e\ndocker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-620-UBI-98efc75e

@github-actions GitHub Actions
Copy link

@fdberlking Images are available for testing. docker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-620-e167eefa\ndocker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-620-UBI-e167eefa

@fdberlking
Copy link
Contributor Author

Could someone please approve this minor documentation change? Thank you!

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 2, 2024

@fdberlking Images are available for testing. docker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-620-8cbb6d48\ndocker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-620-UBI-8cbb6d48

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2024

@karl-johan-grahn Images are available for testing. docker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-620-c2a59d38\ndocker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-620-UBI-c2a59d38

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2024

@fdberlking Images are available for testing. docker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-620-8c255a9f\ndocker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-620-UBI-8c255a9f

karl-johan-grahn
karl-johan-grahn requested changes Apr 3, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2024

@karl-johan-grahn Images are available for testing. docker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-620-41acabd8\ndocker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-620-UBI-41acabd8

@fdberlking
issue/562 - changed from helm to bash where needed
96d8f16 
Signed-off-by: Benjamin Walterscheid <52604859+fdberlking@users.noreply.github.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2024

@fdberlking Images are available for testing. docker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-620-96d8f164\ndocker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-620-UBI-96d8f164

@karl-johan-grahn karl-johan-grahn merged commit fc60755 into stakater:master Apr 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@karl-johan-grahn karl-johan-grahn karl-johan-grahn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ENHANCE] Documentation for Reloader Chart values.yaml
2 participants
@fdberlking @karl-johan-grahn