Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tell Go runtime about the CPU & memory limits. #699

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

mindw
Copy link
Contributor

@mindw mindw commented Jun 22, 2024

Copy link

@mindw Images are available for testing. docker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-699-7e7e3d80\ndocker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-699-UBI-7e7e3d80

@bnallapeta
Copy link

@mindw Thanks for the PR.
Could you update the PR description clearly to reflect the purpose of your changes?

Also, you cannot update this file directly as it is a generated file from our pipelines.

Copy link

@mindw Images are available for testing. docker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-699-72c623b0\ndocker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-699-UBI-72c623b0

@mindw
Copy link
Contributor Author

mindw commented Jun 24, 2024

@mindw Thanks for the PR. Could you update the PR description clearly to reflect the purpose of your changes?

Also, you cannot update this file directly as it is a generated file from our pipelines.

@bnallapeta , Thank you for looking into this and the pointing this out.

Updated the helm chart and provided links in the description.

Copy link

@mindw Images are available for testing. docker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-699-a01a6749\ndocker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-699-UBI-a01a6749

Copy link

@mindw Images are available for testing. docker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-699-658cb7c1\ndocker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-699-UBI-658cb7c1

@bnallapeta
Copy link

@mindw I think we are good to merge this pending one last comment.

@bnallapeta
Copy link

@mindw gentle reminder.

mindw added 2 commits July 27, 2024 17:37
Signed-off-by: Gabi Davar <grizzly.nyo@gmail.com>
Copy link

@mindw Images are available for testing. docker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-699-36484c30\ndocker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-699-UBI-36484c30

@bnallapeta bnallapeta merged commit 12b9a19 into stakater:master Aug 7, 2024
5 checks passed
@stefanandres
Copy link

stefanandres commented Aug 7, 2024

This change broke HA and the default setting, see #723

@mindw mindw deleted the patch-1 branch August 10, 2024 09:33
@mindw mindw restored the patch-1 branch August 10, 2024 09:33
@mindw mindw deleted the patch-1 branch August 10, 2024 09:33
@mindw
Copy link
Contributor Author

mindw commented Aug 10, 2024

@stefanandres sorry about that :( most likely a merge artifact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants