Modal needs to be wider #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@humansinstitute Could you please review the PR as tests will pass? |
tobi-bams
requested changes
Nov 18, 2024
| @@ -1366,13 +1366,20 @@ export const StoriesButtonGroup = styled.div` | |||
|
|
|||
| export const GenerateStoriesModal = styled.div` | |||
| background: #fff; | |||
| width: 600px; | |||
| width: 800px; | |||
There was a problem hiding this comment.
Please can we use percentages here rather than using an absolute value.
Like we want to use 65%.
And maybe add for smaller screens and the width could be 90%
There was a problem hiding this comment.
Sorry, I have seen your comments now 😔
You are right we should have to be used a dynamic style approach
| `; | ||
|
|
||
| export const GenerateStoriesText = styled.p` | ||
| font-family: 'Barlow', sans-serif; | ||
| font-size: 18px; | ||
| color: #5f6368; | ||
| margin: 0; | ||
| width: 500px; | ||
| width: 650px; |
There was a problem hiding this comment.
Here also, can we use a width of 100% so the content just take the width of it's container. Using absolute width always caused issue because users always have different screen size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number : #647
Link
Clone: #647
Evidence:
https://www.loom.com/share/f471dec147274d409f065e05bab632ee?sid=838244b6-a6bc-4f34-9ab8-91338d4847a1
Type of change
Please delete options that are not relevant.
Checklist before requesting a review