moved extra functions to helpers instead and added test coverage (#1176)

frontend/app/src/helpers/__test__/helpers.spec.ts

@@ -10,7 +10,9 @@ import {
   spliceOutPubkey,
   userHasManageBountyRoles,
   RolesCategory,
-  handleDisplayRole
+  handleDisplayRole,
+  formatSat,
+  filterCount
 } from '../helpers-extended';
 
 beforeAll(() => {
@@ -260,5 +262,15 @@ describe('testing helpers', () => {
         role5: true
       });
     });
+
+    test('formatSat', () => {
+      expect(formatSat(10000)).toBe('10 000');
+      expect(formatSat(0)).toBe('0');
+    });
+    test('filterCount', () => {
+      expect(filterCount({ thing1: 0, thing2: 1 })).toBe(1);
+      expect(filterCount({ thing1: 1, thing2: 1 })).toBe(2);
+      expect(filterCount({})).toBe(0);
+    });
   });
 });

frontend/app/src/helpers/helpers-extended.ts

@@ -2,6 +2,25 @@
 import LighningDecoder from 'light-bolt11-decoder';
 import { getHost } from '../config/host';
 
+export const filterCount = (filterValues: any) => {
+  let count = 0;
+  for (const [, value] of Object.entries(filterValues)) {
+    if (value) {
+      count += 1;
+    }
+  }
+  return count;
+};
+
+export const formatSat = (sat: number) => {
+  if (sat === 0 || !sat) {
+    return '0';
+  }
+  const satsWithComma = sat.toLocaleString();
+  const splittedSat = satsWithComma.split(',');
+  return splittedSat.join(' ');
+};
+
 export const formatPrice = (amount = 0) => amount;
 
 export const formatSatPrice = (amount = 0) => {

frontend/app/src/people/widgetViews/BountyHeader.tsx

@@ -11,7 +11,7 @@ import { colors } from '../../config/colors';
 import { useIsMobile } from '../../hooks';
 import { SearchBar } from '../../components/common/index';
 import { useStores } from '../../store';
-import { filterCount } from '../utils/ExtraFunctions';
+import { filterCount } from '../../helpers';
 import { GetValue, coding_languages, status } from '../utils/languageLabelStyle';
 import { PostBounty } from './postBounty';
 

frontend/app/src/people/widgetViews/PeopleHeader.tsx

@@ -5,7 +5,7 @@ import React, { useState, useEffect } from 'react';
 import { EuiCheckboxGroup, EuiPopover, EuiText } from '@elastic/eui';
 import MaterialIcon from '@material/react-material-icon';
 import { colors } from 'config';
-import { filterCount } from 'people/utils/ExtraFunctions';
+import { filterCount } from '../../helpers';
 import { GetValue, coding_languages } from '../utils/languageLabelStyle';
 
 interface styledProps {

frontend/app/src/people/widgetViews/organization/HistoryModal.tsx

@@ -5,7 +5,7 @@ import moment from 'moment';
 import styled from 'styled-components';
 import { PaymentHistory, OrgTransactionType } from 'store/main';
 import { useStores } from 'store';
-import { formatSat } from 'people/utils/ExtraFunctions';
+import { formatSat } from '../../../helpers';
 import { Modal } from '../../../components/common';
 import { colors } from '../../../config/colors';
 import ArrowRight from '../../../public/static/arrow-right.svg';

frontend/app/src/people/widgetViews/organization/PaidInvoice.tsx

@@ -1,6 +1,6 @@
 import React from 'react';
 import styled from 'styled-components';
-import { formatSat } from 'people/utils/ExtraFunctions';
+import { formatSat } from '../../../helpers';
 
 const Wrapper = styled.div`
   display: flex;