Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have blank description for profiles instead of "description". #1207

Closed
2 tasks
kevkevinpal opened this issue Dec 28, 2023 · 10 comments
Closed
2 tasks

Have blank description for profiles instead of "description". #1207

kevkevinpal opened this issue Dec 28, 2023 · 10 comments
Assignees
Labels
Milestone

Comments

@kevkevinpal
Copy link
Contributor

Describe the bug
Says description when we can keep it simpler with nothing
Screenshot 2023-12-28 at 12 00 12 PM

To Reproduce

  1. Go to people page
  2. Select person
  3. observe side bar

Expected behavior
It should be blank instead of saying description

Acceptance Criteria

  • I have tested on Chrome desktop
  • I have posted a screenshot or video if it is a change in the front end
@kevkevinpal kevkevinpal added bug Something isn't working frontend bounties labels Dec 28, 2023
@wright-eric
Copy link
Contributor

Can i take this up?

@aliraza556
Copy link
Contributor

@kevkevinpal could you assign me this task?

@aliraza556
Copy link
Contributor

Hi @kevkevinpal, I have completed this task. Please see the attached image as evidence.

I have tested all devices, and they are functioning perfectly.

@kevkevinpal
Copy link
Contributor Author

Hi @kevkevinpal, I have completed this task. Please see the attached image as evidence.

* Image#1: [Link](https://i.imgur.com/djNQhIy.png)

* Image#2: [Link](https://i.imgur.com/FV6JQow.png)

* Image#3: [Link](https://i.imgur.com/XuKo9cX.png)

I have tested all devices, and they are functioning perfectly.

I assigned you not sure if we have a bounty up for this yet

@aliraza556
Copy link
Contributor

Thank you, @kevkevinpal, for confirming the assignment. I'm glad to have completed it successfully. Regarding the bounty, it's not a concern at the moment. My primary focus was ensuring the quality and functionality of the devices, which I'm happy to report is excellent. Please let me know if there's anything else I can assist with or any further steps required for this task.

@aliraza556
Copy link
Contributor

Hi @kevkevinpal
I have resolved issue #1217 related to the side-panel display description. Could you please review it and provide your feedback?

@ecurrencyhodler
Copy link
Contributor

Hey @aliraza556 where is the PR for this? I can create a bounty for you.

@ecurrencyhodler ecurrencyhodler changed the title Side panel for people displays description Have blank description for profiles instead of "description". Dec 30, 2023
@ecurrencyhodler
Copy link
Contributor

ecurrencyhodler commented Dec 30, 2023

Ok i see it. here's the bounty: https://community.sphinx.chat/bounty/1024

@aliraza556
Copy link
Contributor

Thank you for following up! I've just submitted the PR for issue #1217 and it's ready for review. However, I committed to the wrong branch, but I will fix it within 10 minutes. Also, I appreciate the offer for a bounty – that's great motivation!

@ecurrencyhodler
Copy link
Contributor

Closed by #1217.

@ecurrencyhodler ecurrencyhodler added this to the Cycle 1 milestone Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

No branches or pull requests

4 participants