fix(side-panel-description): Fixed Side panel for people displays description #1217
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
A bug was identified in the person card display component where the word
description
is incorrectly shown when no description is provided for a person. This is misleading and does not align with intuitive user interface practices.Expected Behavior:
The ideal behavior is for the description field to remain blank when no description is provided. This ensures a cleaner and more professional appearance of the UI, avoiding any confusion for the users.
Issue ticket number and link:
Solution:
The proposed solution involves modifying the condition that checks for and renders the
description
property. The updated condition now checks if thedescription
property exists and is not equal to the placeholder text 'description'. Only when these conditions are met, the description is rendered. This approach effectively handles cases where the description might be absent or not applicable.Changes:
Person
component for both the small and desktop card versions.description
is not displayed when no description is provided.Evidence:
Please see the attached image as evidence.
Testing:
description
.Notes:
Please review the changes and merge this PR if everything is in order. This fix is essential for the upcoming release, and I look forward to any feedback you might have.