Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(side-panel-description): Fixed Side panel for people displays description #1217

Merged

Conversation

aliraza556
Copy link
Contributor

Problem:

A bug was identified in the person card display component where the word description is incorrectly shown when no description is provided for a person. This is misleading and does not align with intuitive user interface practices.

Expected Behavior:

The ideal behavior is for the description field to remain blank when no description is provided. This ensures a cleaner and more professional appearance of the UI, avoiding any confusion for the users.

Issue ticket number and link:

Solution:

The proposed solution involves modifying the condition that checks for and renders the description property. The updated condition now checks if the description property exists and is not equal to the placeholder text 'description'. Only when these conditions are met, the description is rendered. This approach effectively handles cases where the description might be absent or not applicable.

Changes:

  • Updated the conditional rendering logic in the Person component for both the small and desktop card versions.
  • Ensured that the placeholder text description is not displayed when no description is provided.
  • Maintained existing functionality and styling for cases where the description is present.

Evidence:

Please see the attached image as evidence.

Testing:

  • Manually tested the person card component with various states: with description, without description, and with the placeholder text description.
  • Manual testing across different devices and screen resolutions.
  • Verified that no other functionalities are impacted by this change.

Notes:

Please review the changes and merge this PR if everything is in order. This fix is essential for the upcoming release, and I look forward to any feedback you might have.

@aliraza556 aliraza556 force-pushed the Side-panel-displays-description branch from f387495 to da30d46 Compare December 30, 2023 20:52
@aliraza556
Copy link
Contributor Author

aliraza556 commented Dec 30, 2023

Hi @kevkevinpal, I've addressed the issue and updated the code in the correct repository. The changes are now live. Please let me know if there's anything else that needs attention. Thank you!

Please see the attached image as evidence.

@aliraza556
Copy link
Contributor Author

Hi @kevkevinpal
I hope you're having a wonderful New Year's celebration! Just wanted to drop a quick note to let you know that I've addressed the issue and updated the code in the correct repository.

Please take a look at your earliest convenience. There's no rush, considering the holiday. Let me know if there's anything else that needs attention when you're back.

Thank you and Happy New Year!

@kevkevinpal
Copy link
Contributor

looks good to me nice work, I'm going to manually change the description on the db to be blank aswell and maybe in the future we can remove the custom code to make the words "description" disappear

@kevkevinpal kevkevinpal merged commit 73326a3 into stakwork:master Jan 2, 2024
4 of 5 checks passed
@aliraza556
Copy link
Contributor Author

Hi @kevkevinpal,
Fantastic! I'm glad to hear the updates look good on your end. I appreciate your initiative to adjust the description in the database too. That sounds like a prudent step for now.

elraphty pushed a commit that referenced this pull request Jan 26, 2024
…cription (#1217)

* fix(side-panel-description): fixed side panel for people displays description

* fix(updated-side-panel-description): fixed side panel for people displays description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants