Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: url regression #1016

Merged
merged 2 commits into from
Nov 28, 2023
Merged

fix: url regression #1016

merged 2 commits into from
Nov 28, 2023

Conversation

Jeezman
Copy link
Contributor

@Jeezman Jeezman commented Nov 27, 2023

closes #998

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@ecurrencyhodler
Copy link
Contributor

@elraphty jeezman thinks we should distinguish bounty urls inside the org.

"I think thats what users will expect. And it signifies viewing bounties within the organization. It's also more maintainble and easier to write tests against."

What do you think?

@kevkevinpal
Copy link
Contributor

@elraphty jeezman thinks we should distinguish bounty urls inside the org.

"I think thats what users will expect. And it signifies viewing bounties within the organization. It's also more maintainble and easier to write tests against."

What do you think?

I agree idk what adding 'org' to the URL path does other than say there is a org attached to the bounty and most users don't even care what the URL looks like and its still a bounty and the id is still the exact same and this simplifies the code, I think this is a good change nice work @Jeezman

@elraphty thoughts?

@kevkevinpal kevkevinpal merged commit d9021b9 into stakwork:master Nov 28, 2023
5 checks passed
@ecurrencyhodler
Copy link
Contributor

Tested and works great. Thanks Jeezman for the fast follow.

@kevkevinpal
Copy link
Contributor

Tested and works great. Thanks Jeezman for the fast follow.

did you test on staging? not sure if its updated yet

@ecurrencyhodler
Copy link
Contributor

I did and I didn't see the org url path. I can double check again soon.

elraphty pushed a commit that referenced this pull request Jan 26, 2024
* fix: url regression

* fix: lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix url regression in org url page when viewing a bounty.
3 participants