Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat✨: Added Load More button functionality to assigned bounties #1119

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Feat✨: Added Load More button functionality to assigned bounties #1119

merged 2 commits into from
Dec 18, 2023

Conversation

VividhPandey003
Copy link
Contributor

Describe your changes

  1. Updated the visible tickets count to 20
  2. Added a Load More button

Issue ticket number and link

Closes #1074

Type of change

loadmore.mov

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested on Chrome and Firefox
  • I have tested on a mobile device
  • I have provided a screenshot or recording of changes in my PR if there were updates to the frontend

Signed-off-by: Vividh Pandey <vividh.pandey.13@gmail.com>
Signed-off-by: Vividh Pandey <vividh.pandey.13@gmail.com>
@ecurrencyhodler
Copy link
Contributor

LGTM! Nice change to show 20 at first. Let's get a code review. Also @VividhPandey003 could the initial # to show bounties affect other areas of the website like the homepage or viewing created bounties in the profile?

@VividhPandey003
Copy link
Contributor Author

LGTM! Nice change to show 20 at first. Let's get a code review. Also @VividhPandey003 could the initial # to show bounties affect other areas of the website like the homepage or viewing created bounties in the profile?

I don't think so. I could reverify this in local. Could you please explain it more

@ecurrencyhodler
Copy link
Contributor

Check the home page to see how many bounties appear and see if it's 20 and if anything breaks. Currently I think it's 10.

Also go to your profile and click "Bounties" tab and see how many get initially displayed.

If the amount increases then that's no big deal. But if there's a breaking change, we should make some changes. Thanks!

@VividhPandey003
Copy link
Contributor Author

l. But if there's a breaking change, we should make some changes. Thanks!

loadmorebog.mov

@ecurrencyhodler
Copy link
Contributor

Nice. Let's get a code review.

@kevkevinpal kevkevinpal merged commit 68a7029 into stakwork:master Dec 18, 2023
6 checks passed
@VividhPandey003 VividhPandey003 deleted the ticketsloadmore branch December 20, 2023 12:52
elraphty pushed a commit that referenced this pull request Jan 26, 2024
* Added Load More button functionality to user tickets

Signed-off-by: Vividh Pandey <vividh.pandey.13@gmail.com>

* Prettier fix

Signed-off-by: Vividh Pandey <vividh.pandey.13@gmail.com>

---------

Signed-off-by: Vividh Pandey <vividh.pandey.13@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a "load more" button to assigned tickets in profile
3 participants