Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat✨: Added dynamic placeholder text to Post A Bounty Modal #1145

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Feat✨: Added dynamic placeholder text to Post A Bounty Modal #1145

merged 1 commit into from
Dec 19, 2023

Conversation

VividhPandey003
Copy link
Contributor

Describe your changes

bugfix.placeholder.mov

Issue ticket number and link

Closes #1041

Type of change

  1. Added placeholder text to textarea input:
  • Description: Implemented a placeholder text for improved user guidance within the textarea input.
  • Reasoning: Enhances user experience by providing context and expectations for the input field.
  1. Fixed the top spacing of placeholder:
  • Description: Adjusted the spacing of the placeholder text to ensure a visually polished appearance.
  • Reasoning: Aesthetic improvement to maintain a consistent and appealing design.
  1. Placeholder text to only get displayed when github_description is not selected:
  • Description: Modified the behavior of the placeholder text to appear only when the github_description option is not selected.
  • Reasoning: Aligns with the user interface logic, showing placeholder text relevant to the selected options.

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested on Chrome and Firefox
  • I have tested on a mobile device
  • I have provided a screenshot or recording of changes in my PR if there were updates to the frontend

Signed-off-by: Vividh Pandey <vividh.pandey.13@gmail.com>
@ecurrencyhodler
Copy link
Contributor

Beautiful thank you!!!! Really amazing work and great attention to detail. Let's do a code review.

@kevkevinpal
Copy link
Contributor

@ecurrencyhodler might be more than needed we could populate the desc field when we hit the toggle with the actual desc from github if the link is valid aswell

@kevkevinpal kevkevinpal merged commit 9c8804f into stakwork:master Dec 19, 2023
6 checks passed
@ecurrencyhodler
Copy link
Contributor

That would be amazeballs. We should also add a feature to manually enlarge the size of the window as well to view the whole text.

@ecurrencyhodler
Copy link
Contributor

Tested on staging. great work! Looks smooth. Paying you out now.

@VividhPandey003 VividhPandey003 deleted the defaultText branch December 20, 2023 12:52
elraphty pushed a commit that referenced this pull request Jan 26, 2024
Signed-off-by: Vividh Pandey <vividh.pandey.13@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add default text in bounty creation flow
3 participants