Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed the small white module that appeared when clicking on bounty #1029 #1174

Merged
merged 5 commits into from
Dec 26, 2023
Merged

Conversation

Vayras
Copy link
Contributor

@Vayras Vayras commented Dec 22, 2023

This bug was caused by the fact that the modal was rendered even before the data was fetched, and re-rendered again when the data was finally fetched

to fix this proper loading state has been implemented , fixes #1029

video demo

My.Movie.mp4

@kevkevinpal
Copy link
Contributor

this commit is unrelated to this PR please remove dacad26

@kevkevinpal
Copy link
Contributor

looks like the one commit with the width is still there

@ecurrencyhodler
Copy link
Contributor

@Vayras good job finding a fix and thanks for documenting it in the PR. That's very helpful.

Address kev's comments and we can get this merged.

@Vayras
Copy link
Contributor Author

Vayras commented Dec 22, 2023

this commit is unrelated to this PR please remove dacad26

Hi , @kevkevinpal I ran a git rebase and Removed the commit from the PR , let me just try deleting the file

@Vayras
Copy link
Contributor Author

Vayras commented Dec 22, 2023

@Vayras good job finding a fix and thanks for documenting it in the PR. That's very helpful.

Address kev's comments and we can get this merged.

Will Do that surely, Thanks

@Vayras
Copy link
Contributor Author

Vayras commented Dec 22, 2023

@kevkevinpal Removed the Commit from the PR , let me know if there are any more changes , Thanks

@elraphty
Copy link
Contributor

elraphty commented Dec 26, 2023

Looks good to me @ecurrencyhodler

@elraphty elraphty merged commit 34601cf into stakwork:master Dec 26, 2023
5 checks passed
@ecurrencyhodler
Copy link
Contributor

I tested and it works. Great jbo with this vayras. It's super smooth now. Will pay you out soon.

@Vayras
Copy link
Contributor Author

Vayras commented Dec 27, 2023

I tested and it works. Great jbo with this vayras. It's super smooth now. Will pay you out soon.

@ecurrencyhodler Thanks

elraphty added a commit that referenced this pull request Jan 26, 2024
removed the small white module that appeared when clicking on bounty #1029
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove small white module that appears before viewing a bounty from profile
4 participants