Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test cases #1181

Merged
merged 1 commit into from
Dec 24, 2023
Merged

test cases #1181

merged 1 commit into from
Dec 24, 2023

Conversation

KumarNayan
Copy link
Contributor

@KumarNayan KumarNayan commented Dec 23, 2023

Added test cases

#1165

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested on Chrome and Firefox
  • I have tested on a mobile device

@kevkevinpal
Copy link
Contributor

if you can add a more descriptive title that would be helpful

@kevkevinpal
Copy link
Contributor

looks like prettier job is failing

 [warn] src/pages/superadmin/accessDenied/AccessDenied.Spec.tsx
[warn] Code style issues found in the above file. Run Prettier to fix.

I wouldn't worry about this since its your first PR but if you run
yarn run prettier before committing it should solve that job

@kevkevinpal
Copy link
Contributor

also one last thing is that if you're linking the issue add the key word closes before the issue number to auto close after merge like so

closes #1165

@kevkevinpal
Copy link
Contributor

Nice work tho looking forward to more!

@kevkevinpal kevkevinpal merged commit e5329ee into stakwork:master Dec 24, 2023
4 of 5 checks passed
@KumarNayan
Copy link
Contributor Author

Thanks @kevkevinpal I will take care of the points mentioned.

elraphty pushed a commit that referenced this pull request Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants