fix(#1193):fixed icon displacement on window scaling #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Let's get a code review. |
kevkevinpal
reviewed
Dec 28, 2023
| opacity: ${({ disabled }: ButtonContainerProps) => (disabled ? 0.8 : 1)}; | ||
| margin-top: ${(p: any) => p?.topMargin}; | ||
| background: #ffffff; | ||
| border: 1px solid #dde1e5; | ||
| border-radius: 30px; | ||
| user-select: none; | ||
| .ImageContainer { | ||
| position: absolute; | ||
| /* position: absolute; */ |
There was a problem hiding this comment.
delete instead of commenting
kevkevinpal
reviewed
Dec 28, 2023
Comment on lines
37
to
39
| /* position: absolute; */ | ||
| /* min-height: 48px; | ||
| min-width: 48px; */ |
There was a problem hiding this comment.
delete instead of commenting
|
@kevkevinpal made the changes |
|
Tested on staging. looks good. paying it out now. |
|
jk kev already did! |
elraphty
pushed a commit
that referenced
this pull request
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the displacement of icons with this PR fixes #1193
cause: use of position:absolute in the styles
fix: removing position absolute and using css padding as props to position icons and text correctly
video
Screen.Recording.2023-12-27.at.11.38.10.PM.mov
tested on Chrome and Firefox