-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
freeze admin bounty overview section #1243
freeze admin bounty overview section #1243
Conversation
- wrapped intersection observer logic in a custom hook - hook return a boolean that tells whether or not an node is in view - hook also return a ref for the node we are observing
Hey @Ekep-Obasi it looks like two of your tests are failing. Can you take another look? Let us know if you need some help. |
Yes @ecurrencyhodler |
@kevkevinpal @elraphty can you give some insight here? |
@Ekep-Obasi your prettier is also failing to run |
@elraphty, Do you mean that I should write tests for the component I just created? And for the prettier error in |
I would create a test that covers |
@kevkevinpal Thanks for the help! |
@kevkevinpal @elraphty But the jest workflow is failing with this error
|
top: 62px; | ||
left: 0; | ||
width: 100%; | ||
z-index: 9999999; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this z-index
doesnt feel like best practice is there a style to keep it always ontop? if you can look into alternatives to doing this that would be good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just going to make this another issue so we can merge this PR for now
Tested on staging and it looks good! Paid. |
Increased it to 300k for you. |
@ecurrencyhodler thank you 🙏 |
* feat: created useInViewPort custom hook - wrapped intersection observer logic in a custom hook - hook return a boolean that tells whether or not an node is in view - hook also return a ref for the node we are observing * feat: freeze bounties overview section * refactor: refactored proptypes * test: wrote tests for useInViewport hook * feat: freeze bounties overview section
* feat: created useInViewPort custom hook - wrapped intersection observer logic in a custom hook - hook return a boolean that tells whether or not an node is in view - hook also return a ref for the node we are observing * feat: freeze bounties overview section * refactor: refactored proptypes * test: wrote tests for useInViewport hook * feat: freeze bounties overview section
Describe your changes
Freeze bounty overview on scroll using IntersectionObserver
Reason for Intersection Observer:
Issue ticket number and link #1014
Preview
https://www.loom.com/share/bf450b3c9b6d4a778a1f2c32184b57bd?sid=7662d832-11e2-40a4-b5dc-15bf069aceec
Type of change
Please delete options that are not relevant.
Checklist before requesting a review