Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed description img code from bounty desc #1270

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Removed description img code from bounty desc #1270

merged 2 commits into from
Jan 8, 2024

Conversation

VividhPandey003
Copy link
Contributor

@VividhPandey003 VividhPandey003 commented Jan 6, 2024

Describe your changes

Removed the description image code from the Bounty Header. Could not find any other place where description image was getting affected by removing this part of code.

Issue ticket number and link

Closes #1242

Type of change

Before:

image

After:

image

issuefixed.mov

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested on Chrome and Firefox
  • I have tested on a mobile device
  • I have provided a screenshot or recording of changes in my PR if there were updates to the frontend

Signed-off-by: Vividh Pandey <vividh.pandey.13@gmail.com>
@VividhPandey003
Copy link
Contributor Author

I would need a code review for this. I am quite not sure if this is was the change you had on your mind.

@VividhPandey003 VividhPandey003 changed the title Removed descriptionimg code from bounty desc Removed description img code from bounty desc Jan 6, 2024
Signed-off-by: Vividh Pandey <vividh.pandey.13@gmail.com>
@ecurrencyhodler
Copy link
Contributor

@VividhPandey003 can you post a video of you click on the bounty? We ran into a similar issue last time where the image wasn't displayed inside the bounty page.

@VividhPandey003
Copy link
Contributor Author

Okay yes. On it

@VividhPandey003
Copy link
Contributor Author

VividhPandey003 commented Jan 6, 2024

@ecurrencyhodler I've updated the pr description above with a video.

@ecurrencyhodler
Copy link
Contributor

Thanks the video and screenshots lgtm. Yeah let's get a code review. Good work.

@elraphty elraphty merged commit e978932 into stakwork:master Jan 8, 2024
5 checks passed
@ecurrencyhodler
Copy link
Contributor

Paid!

elraphty added a commit that referenced this pull request Jan 26, 2024
Removed description img code from bounty desc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove image from bounty that is being displayed on the home page
3 participants