Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button rename #1290

Merged
merged 4 commits into from
Jan 9, 2024
Merged

Button rename #1290

merged 4 commits into from
Jan 9, 2024

Conversation

gouravmpk
Copy link
Contributor

@gouravmpk gouravmpk commented Jan 8, 2024

Describe your changes

"Mark as Unpaid" when bounty is paid

Issue ticket number and link

#1279

Type of change

Text (UI)

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested on Chrome and Firefox
  • I have tested on a mobile device
  • I have provided a screenshot or recording of changes in my PR if there were updates to the frontend

@ecurrencyhodler
Copy link
Contributor

Can you post a screenshot @gouravmpk ?

@gouravmpk
Copy link
Contributor Author

image

@ecurrencyhodler
Copy link
Contributor

Can you show the state where it is paid? That state needs to show "mark as unpaid".

@gouravmpk
Copy link
Contributor Author

image
@ecurrencyhodler @elraphty

@elraphty elraphty merged commit 8448d68 into stakwork:master Jan 9, 2024
5 checks passed
@ecurrencyhodler
Copy link
Contributor

@gouravmpk can you do a quick follow up and add the following test?

  • If bounty status is paid, show "Mark as Unpaid" in the button?

@ecurrencyhodler
Copy link
Contributor

I"ll increase the bounty by 100k sats.

@gouravmpk
Copy link
Contributor Author

@gouravmpk can you do a quick follow up and add the following test?

  • If bounty status is paid, show "Mark as Unpaid" in the button?

Will do

@ecurrencyhodler
Copy link
Contributor

elraphty added a commit that referenced this pull request Jan 26, 2024
elraphty added a commit that referenced this pull request Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants