Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement bounty sort by newest and oldest #1340

Closed
wants to merge 7 commits into from
Closed

Implement bounty sort by newest and oldest #1340

wants to merge 7 commits into from

Conversation

Ekep-Obasi
Copy link
Contributor

Pull Request Description

  • Implemented sort functionality by adding options to sort by newest and oldest
  • Refactored the super admin logic by moving it into a reusable hook
  • Extracted the getBountyStatus function into a utility folder, enhancing code organization. Additionally, tests have been added to ensure the correctness and reliability of the extracted function.

Issue ticket number and link #1012

Preview

https://www.loom.com/share/d8fd496cd9c645e4ba55dfaea29328a2?sid=baecdcdc-00dc-42fd-a755-9a968d65237e

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested on Chrome and Firefox
  • I have provided a screenshot or recording of changes in my PR if there were updates to the frontend

@ecurrencyhodler
Copy link
Contributor

@Ekep-Obasi thanks for the latest update. Looks like prettier is failing. Can you address that?

@elraphty
Copy link
Contributor

Please fix the prettier error by running yarn run prettier in frontend/app @Ekep-Obasi

@Ekep-Obasi
Copy link
Contributor Author

@elraphty I keep running into this same issue where prettier validates locally but the workflow fails

Capture

Please do you have a clue?

@Vayras
Copy link
Contributor

Vayras commented Jan 18, 2024

@Ekep-Obasi use "yarn run prettier" once , and check for the files changed in git and let me know , I see you have ran prettier:check and It has resulted in no errors

@Ekep-Obasi
Copy link
Contributor Author

@Ekep-Obasi use "yarn run prettier" once , and check for the files changed in git and let me know , I see you have ran prettier:check and It has resulted in no errors

git status shows no changed file
@Vayras thanks

@Vayras
Copy link
Contributor

Vayras commented Jan 18, 2024

@Ekep-Obasi I think the issue might be with the different prettier version between your local machine and on github here are some steps that might help you
1.Take the latest pull on your fork
2. "cd frontend/app" on your local machine
3. remove node modules "rm -rf node_modules"
4. run "npm i --legacy-peer-deps"
5. run "yarn install"
6. run "yarn run prettier now"

@elraphty
Copy link
Contributor

elraphty commented Jan 18, 2024

@elraphty I keep running into this same issue where prettier validates locally but the workflow fails

Capture

Please do you have a clue?

Rebase to the master branch
Delete your node_modoules and yarn.lock file
reinstall the modules, then run 
yarn run prettier in frontend/app

@Ekep-Obasi
Copy link
Contributor Author

@elraphty @Vayras
I have reinstalled prettier
When I run prettier and check git, this is what I have warning: LF will be replaced by CRLF

@Vayras
Copy link
Contributor

Vayras commented Jan 18, 2024

@Ekep-Obasi do you see files changed in the source control panel of vscode?

@Ekep-Obasi
Copy link
Contributor Author

@Vayras @elraphty Thank you for the help!

@Ekep-Obasi Ekep-Obasi closed this Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants