Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend [Integration Test] tribes.go handlers GetTribe, CreateOrEditTribe, & GetTribeByUniqueName #1545

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

FaisalIqbal211
Copy link
Contributor

@FaisalIqbal211 FaisalIqbal211 commented Feb 21, 2024

Describe your changes

Implemented unit tests for tribes handlers to test GetTribe, CreateOrEditTribe and GetTribeByUniqueName methods

image image

Issue ticket number and link

Closes #1533

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested on Chrome and Firefox
  • I have tested on a mobile device
  • I have provided a screenshot or recording of changes in my PR if there were updates to the frontend

@FaisalIqbal211
Copy link
Contributor Author

Note:

The first two scenarios (Should test that a tribe can be fetched by its uuid and Should test that a non-existent uuid returns no tribe) are already covered here

@AbdulWahab3181
Copy link
Contributor

@FaisalIqbal211, I have reviewed the changes, and everything is perfect and working as expected. Great Job! @ecurrencyhodler, could you please approve the workflow? This will ensure that all test units are passing on GHA.

@elraphty
Copy link
Contributor

please fix merge conflicts @FaisalIqbal211

@FaisalIqbal211
Copy link
Contributor Author

@elraphty Done

@elraphty
Copy link
Contributor

elraphty commented Feb 21, 2024

@FaisalIqbal211 you didn't test for this

  • Should test that a tribe can be fetched by its uuid
  • Should test that a non-existent uuid returns no tribe

@FaisalIqbal211
Copy link
Contributor Author

@FaisalIqbal211 you didn't test for this

  • Should test that a tribe can be fetched by its uuid
  • Should test that a non-existent uuid returns no tribe

@elraphty These scenarios are already covered. As you can see here

@elraphty elraphty merged commit c3272cf into stakwork:master Feb 21, 2024
1 check passed
@ecurrencyhodler
Copy link
Contributor

Paid 200k sats! https://community.sphinx.chat/bounty/1538

@FaisalIqbal211
Copy link
Contributor Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backend [Integration Test] tribes.go handlers GetTribe, CreateOrEditTribe, & GetTribeByUniqueName
4 participants