Stakwork Youtube Download #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elraphty
requested review from
tomastiminskas,
Evanfeenstra,
kevkevinpal and
soup20
kevkevinpal
reviewed
Jul 7, 2023
handlers/feed.go
Outdated
| data = append(data, i.Link) | ||
| } | ||
|
|
||
| stakworkKey := fmt.Sprintf("Token token=%s", os.Getenv("STAKWORK_KEY")) |
There was a problem hiding this comment.
We should document this new ENV var somewhere, is there a wiki for this repo or in the readme we can add that
There was a problem hiding this comment.
We shouldn't do this function call either if this key doesn't exist as the request will always fail so we should check for that aswell
There was a problem hiding this comment.
Ok, thanks @kevkevinpal I have pushed the updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This feature sends a request to download youtube videos to Stakwork when a user hits the Tribes server feed?url= endpoint.
Issue ticket number and link
Senza-Lnd issue
Type of change
Checklist before requesting a review