Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finished the feed download fix #618

Merged
merged 4 commits into from
Aug 3, 2023
Merged

finished the feed download fix #618

merged 4 commits into from
Aug 3, 2023

Conversation

elraphty
Copy link
Contributor

@elraphty elraphty commented Aug 3, 2023

Describe your changes

This PR allows youtube videos to be downloaded by Stakwork with specifying Channel IDs.

Issue ticket number and link

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested on Chrome and Firefox
  • I have tested on a mobile device

handlers/feed.go Outdated Show resolved Hide resolved
Copy link
Contributor

@kevkevinpal kevkevinpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good just added one comment about failing fast in the for loop.

handlers/feed.go Outdated Show resolved Hide resolved
Copy link
Contributor

@kevkevinpal kevkevinpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@elraphty elraphty merged commit a3513ba into master Aug 3, 2023
3 checks passed
@Evanfeenstra Evanfeenstra deleted the fix/feed_fix branch January 26, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants