Feat/org bounty payment #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevkevinpal
reviewed
Sep 6, 2023
kevkevinpal
reviewed
Sep 6, 2023
kevkevinpal
reviewed
Sep 6, 2023
frontend/app/src/people/widgetViews/summaries/wantedSummaries/CodingBounty.tsx
Show resolved
Hide resolved
kevkevinpal
reviewed
Sep 7, 2023
db/config.go
Outdated
Comment on lines
236
to
237
| hasRole = true | ||
| return hasRole |
There was a problem hiding this comment.
can just do return true here
Suggested change
| hasRole = true | |
| return hasRole | |
| return true |
kevkevinpal
reviewed
Sep 7, 2023
| if pubKeyFromAuth != org.OwnerPubKey { | ||
| userRoles := DB.GetUserRoles(uuid, pubKeyFromAuth) | ||
| hasRole = RolesCheck(userRoles, role) | ||
| return hasRole |
There was a problem hiding this comment.
can change to return false
Suggested change
| return hasRole | |
| return false |
kevkevinpal
reviewed
Sep 7, 2023
|
|
||
| func UserHasAccess(pubKeyFromAuth string, uuid string, role string) bool { | ||
| org := DB.GetOrganizationByUuid(uuid) | ||
| var hasRole bool = false |
There was a problem hiding this comment.
can remove this line if you do the two comments below
kevkevinpal
reviewed
Sep 7, 2023
kevkevinpal
reviewed
Sep 7, 2023
kevkevinpal
reviewed
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This feature allows organizations to add budget and pay bounty from the budget
Issue ticket number and link
Type of change
Checklist before requesting a review