Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix share to twitter handler #677

Merged
merged 3 commits into from
Sep 14, 2023
Merged

Conversation

maradondt
Copy link
Contributor

Describe your changes

Issue ticket number and link

#654

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested on Chrome and Firefox
  • I have tested on a mobile device

@maradondt
Copy link
Contributor Author

Screen.Recording.2023-09-14.at.10.52.38.mov
Screen.Recording.2023-09-14.at.10.50.34.mov

@ecurrencyhodler
Copy link
Contributor

This looks great! Thanks for submitting it. Would it be possible to have the link and hashtags in their own separate row?

@ecurrencyhodler
Copy link
Contributor

Let's update the format to the following:

I just created a bounty on Sphinx Community: {bounty title}
{hashtags}
{link}

@maradondt
Copy link
Contributor Author

changed, but I cant reorder hashtags and link

Screenshot 2023-09-14 at 21 26 34

Let's update the format to the following:

I just created a bounty on Sphinx Community: {bounty title} {hashtags} {link}

@ecurrencyhodler
Copy link
Contributor

Okay that works for now thanks!

owner_id: ownerPubkey,
created: issueCreated
};
const bountyUrl = new URL('https://community.sphinx.chat/tickets');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this may change depeneding on where it is deployed we probably don't want to hard code this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to merge it for now though

created this issue to resolve this
#687

@kevkevinpal kevkevinpal merged commit 682a368 into stakwork:master Sep 14, 2023
2 of 3 checks passed
@ecurrencyhodler
Copy link
Contributor

@maradondt FYI in the future if you use the language "closes #654" in the description, github will automatically close the issue it's tied to.

Great work and thanks for the PR. Kev is going to work on getting you paid out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants