Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ability to unassign user #709

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Conversation

maradondt
Copy link
Contributor

Describe your changes

Issue ticket number and link

closes #659

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested on Chrome and Firefox
  • I have tested on a mobile device

@maradondt
Copy link
Contributor Author

Screen.Recording.2023-09-16.at.17.23.05.mov

@maradondt
Copy link
Contributor Author

maradondt commented Sep 16, 2023

@kevkevinpal I think it needs also a backend fix, because I have to set in assignee not empty value for it to work
newBody.assignee = 'emptyid';

@kevkevinpal
Copy link
Contributor

@kevkevinpal I think it needs also a backend fix, because I have to set in assignee not empty value for it to work newBody.assignee = 'emptyid';

ok I can open another issue to fix this on the backend but this works for now!

@kevkevinpal kevkevinpal merged commit 835d243 into stakwork:master Sep 18, 2023
2 of 3 checks passed
@ecurrencyhodler
Copy link
Contributor

So I tested this in staging: https://people-test.sphinx.chat/tickets

The ticket now immediately disappears when I assign someone. Could that have been introduced in this PR?

ticket.disappears.mov

@kevkevinpal
Copy link
Contributor

So I tested this in staging: https://people-test.sphinx.chat/tickets

The ticket now immediately disappears when I assign someone. Could that have been introduced in this PR?
ticket.disappears.mov

looks like it worked on the test server for you maybe we should have it refresh and show on the top maybe the last updated field is not changing

@maradondt
Copy link
Contributor Author

maradondt commented Sep 18, 2023

The ticket now immediately disappears when I assign someone.

@ecurrencyhodler
I didn't change the logic, everything works the same as before the fix, but if needed I can disable the modal close after the reassignment.

@ecurrencyhodler
Copy link
Contributor

Okay. For some reason I thought the window persisted after someone was assigned. My apologies. Let me create a separate issue. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to unassign a bounty taker from a bounty
3 participants