Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added view budget histories component #717

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

elraphty
Copy link
Contributor

Describe your changes

This PR adds the view of the budget payment history component

Issue ticket number and link

692

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested on Chrome and Firefox
  • I have tested on a mobile device

@ecurrencyhodler
Copy link
Contributor

@elraphty can you update this pr to say "Closes #692"? Let's use this format moving forward. Thanks!

db/structs.go Outdated Show resolved Hide resolved
db/structs.go Outdated Show resolved Hide resolved
@elraphty
Copy link
Contributor Author

@elraphty can you update this pr to say "Closes #692"? Let's use this format moving forward. Thanks!

Okay, thanks @ecurrencyhodler, I didn't add closes because, I'm still working on the link for the bounty on payment history, which requires a refactor to the database query and payment history API, once I'm done with it, I will add "Closes to the next PR".

@ecurrencyhodler
Copy link
Contributor

@elraphty can you update this pr to say "Closes #692"? Let's use this format moving forward. Thanks!

Okay, thanks @ecurrencyhodler, I didn't add closes because, I'm still working on the link for the bounty on payment history, which requires a refactor to the database query and payment history API, once I'm done with it, I will add "Closes to the next PR".

Okay great! SGTM! Also the more you can provide context like that in the description, the better it will help us keep track of how things are split up.

@kevkevinpal
Copy link
Contributor

merging nice work!

@kevkevinpal kevkevinpal merged commit 822e08f into master Sep 18, 2023
2 of 3 checks passed
@Evanfeenstra Evanfeenstra deleted the feat/budget_payment_history branch January 26, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants